Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container name #36

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Container name #36

merged 4 commits into from
Dec 11, 2019

Conversation

Natkeeran
Copy link
Contributor

** Please hold on from testing. Will provide more info. **

GitHub Issue: (link)
Part of the work towards: Islandora/documentation#926

What does this Pull Request do?

This PR accepts fedora_end_point as header argument and uses it to create the fedora resource.

Dependency: Islandora/Alpaca#65

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #36 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #36      +/-   ##
============================================
+ Coverage     92.56%   92.58%   +0.01%     
  Complexity      136      136              
============================================
  Files             9        9              
  Lines           417      418       +1     
============================================
+ Hits            386      387       +1     
  Misses           31       31
Impacted Files Coverage Δ Complexity Δ
src/Client/GeminiClient.php 98.57% <100%> (+0.02%) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5dd422...3c6b124. Read the comment docs.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested with Islandora/Alpaca#65

@dannylamb dannylamb merged commit 4ae10f1 into Islandora:dev Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants