Skip to content

Commit

Permalink
Update build for improved debugability. (#184)
Browse files Browse the repository at this point in the history
* Update build-4.x.yml
* Update tester
* Update composer.json

PHP 8.0 is no longer supported

Require the same version as installed by the main project, similar to nikic/PHP-Parser#1031 (comment)
  • Loading branch information
adam-vessey authored Jan 7, 2025
1 parent 64cb4ce commit a0b33d3
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 6 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/build-4.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ["8.0", "8.1", "8.2"]
php-versions: ["8.1", "8.2", "8.3"]

name: PHP ${{ matrix.php-versions }}

Expand Down Expand Up @@ -66,7 +66,11 @@ jobs:
- name: composer install
run: |
cd $GITHUB_WORKSPACE/build_dir
for D in */; do (cd $D; composer install) done
for D in */; do
echo "::group::composer install under $D"
(cd $D; composer install)
echo "::endgroup"
done
- name: line endings
run: $SCRIPT_DIR/line_endings.sh $GITHUB_WORKSPACE
Expand Down
20 changes: 16 additions & 4 deletions .scripts/tester
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
#!/bin/sh
#!/bin/bash
export SYMFONY_DEPRECATIONS_HELPER=disabled
FAIL=0
FAILED=()
for D in */; do
cd $D
echo "Operating on $D"
echo "::group::Testing $D"
cd $D
composer test
if [ $? -ne 0 ]; then
FAIL=1
FAILED+=($D)
fi
cd ..
cd ..
echo "::endgroup"
done

echo "::group::Summary"
if [ ${#FAILED[@]} -gt 0 ] ; then
echo "Failed tests: ${FAILED[@]}"
else
echo "All tests passed!"
fi
echo "::endgroup"

exit $FAIL
1 change: 1 addition & 0 deletions Homarus/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
],
"test": [
"@check",
"@putenv SYMFONY_PHPUNIT_REQUIRE=\"nikic/php-parser:^4.13\"",
"bin/phpunit"
]
},
Expand Down

0 comments on commit a0b33d3

Please sign in to comment.