Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite as symfony #76

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Rewrite as symfony #76

merged 2 commits into from
Dec 19, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 16, 2019

GitHub Issue: Islandora/documentation#1224

Related PRs:

What does this Pull Request do?

Rewrites the Houdini microservice as Symfony 4.

What's new?

Symfony flex framework, but functionally identical.

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Use: Islandora-Devops/islandora-playbook#136

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #76 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #76   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity      168      168           
=========================================
  Files             9        9           
  Lines           700      700           
=========================================
  Hits            664      664           
  Misses           36       36
Impacted Files Coverage Δ Complexity Δ
Houdini/src/Controller/HoudiniController.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879c9b7...6e59904. Read the comment docs.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-unlv
Copy link
Contributor

@whikloj, there are some composer.lock conflicts that need to be resolved.

@whikloj
Copy link
Member Author

whikloj commented Dec 19, 2019

I had to composer update Houdini but this should be good to go now.

@seth-shaw-unlv seth-shaw-unlv merged commit 463aa7e into dev Dec 19, 2019
@whikloj whikloj deleted the symfony-rewrite branch March 24, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants