Add attribute to allow anonymous GET requests through Syn #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
============================================
+ Coverage 80.93% 86.11% +5.18%
- Complexity 97 116 +19
============================================
Files 6 6
Lines 320 353 +33
Branches 62 65 +3
============================================
+ Hits 259 304 +45
+ Misses 33 24 -9
+ Partials 28 25 -3
Continue to review full report at Codecov.
|
|
I just realized that this should cover |
Clean up allow anonymous checks
|
Testing now... |
|
Works as expected. |
|
@whikloj++ Adding another issue to update syn-settings.xml in claw_vagrant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves: Islandora/documentation#573
What does this Pull Request do?
Adds another attribute to the
siteelementanonymous="(true|false)", to allow you to set some or all sites to allow unauthenticated GET requests.What's new?
This does not clean up the XML validation issues I expressed here, but I figured those could be dealt with later.
This adds in the third parsing of the XML files to generate a map of URL and anonymous check, if a site URL matches the host that is the option used, or if the default is set and no site is specified that is what is used.
Sets credentials as
anonymouswith roles ofanonymousandislandora.Not sure if there is a way to avoid authentication once you have required it, like to avoid creating sessions like @jonathangreen was suggesting. That can come later.
How should this be tested?
./gradlew clean buildbuild/lib/islandora-syn-0.0.1-all.jarto/var/lib/tomcat8/lib/var/lib/tomcat8/conf/syn-settings.xmlsites file include ananonymous='true'option.You should be able to access
http://localhost:8080/fcrepo/restwithout a token, but a POST request will still fail.Interested parties
@jonathangreen @ajs6f @dannylamb