Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] jquery once needs to be replaced for Drupal 10 compatibility #40

Closed
joshdentremont opened this issue Oct 6, 2023 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@joshdentremont
Copy link
Contributor

Creating a site with Drupal 10 and loading a search results page will show JS errors in the console of the format $(...).once is not a function. This results in sorting and facet soft limits not working.

This is due to Drupal dropping jquery.once in favour of a new once() function. More info can be found here: (https://www.drupal.org/project/drupal/issues/3183149)

I was able to fix the once errors by following the examples in the issue above, but now I am getting Ajax errors (screenshots below), so I think more work needs to be done. This fixed the soft limits on facets, but sorting still appears to be broken. You can see my changes at https://github.com/joshdentremont/advanced_search

I'm not sure if my changes are causing the Ajax errors, or if it is a separate issue that only shows up once the once() issues have been fixed

image

Screenshot 2023-10-06 at 3 14 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants