update advanced search for new Drupal "once" function #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Replaces calls to Jquery once with Drupal once function.
After fixing that, we had some issues with the sorting not working. The second and third commits address this. The second commit fixes an Ajax error, and the third commit stops the function from being called twice when the sort dropdown changes.
Related GitHub Issue: ([BUG] jquery once needs to be replaced for Drupal 10 compatibility #40)
Other Relevant Links:
Once replacement instructions: https://www.drupal.org/project/drupal/issues/3183149
Ajax fix: https://www.drupal.org/project/viewsreference/issues/3326841
What's new?
There should be no changes to functionality. This just replaces some deprecated functions.
How should this be tested?
Documentation Status
No documentation changes needed
Additional Notes:
N/A
Interested parties
@Islandora/committers