Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use syntax that works with http-foundation 6. #36

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Aug 14, 2023

What does this Pull Request do?

Solves the problem that advanced search doesn't work in drupal 10.

What's new?

  • Gets a query parameter in a way that accepts arrays or scalars.

  • Does this change add any new dependencies? no, this also works in http-foundation 4 (drupal 9 version)

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no

  • Could this change impact execution of existing code? no

How should this be tested?

Launch a site that is running Drupal 10. Until site-template gets fixed, either:

  • use this PR
  • use commit 0.8.0 of the Starter Site, then update to Drupal 10.

Create some content. Note that you can't use advanced search to find the content and errors appear in the logs. (replicate the bug).
With this PR, you should be able to find content and the logs should have no errors.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___ n/a

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu requested a review from wgilling August 23, 2023 17:17
@wgilling
Copy link

I am trying to use Docker Desktop on my ubuntu machine and I should be able to test this, but it feels like this laptop is going to overheat.

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this after running it this issue today. Searches are working again with no errors reported in the logs.

@rosiel rosiel removed the request for review from wgilling September 25, 2023 16:19
@aOelschlager aOelschlager merged commit 15703a1 into 2.x Sep 25, 2023
@rosiel rosiel deleted the rosiel-patch-1 branch September 25, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants