Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecoverage for prepareUri #53

Merged
merged 8 commits into from
Jul 26, 2016
Merged

Codecoverage for prepareUri #53

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b90800f
Let's see what this does.
ruebot Jul 22, 2016
95e7be9
Let's see what this does... again.
ruebot Jul 22, 2016
63ce834
I can't read
ruebot Jul 22, 2016
6e79a1a
Add a bit more.
ruebot Jul 22, 2016
c4443bf
I hope this is sane.
ruebot Jul 22, 2016
7d407f0
Merge branch 'master' into jaredsidea
ruebot Jul 26, 2016
61682be
Welp, that didn't work.
ruebot Jul 26, 2016
e2e7c0a
Merge branch 'jaredsidea' of github.com:ruebot/chullo into jaredsidea
ruebot Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/CreateTransactionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ class CreateTransactionTest extends \PHPUnit_Framework_TestCase

/**
* @covers Islandora\Chullo\Chullo::createTransaction
* @covers Islandora\Chullo\Chullo::getBaseUri
* @covers Islandora\Chullo\FedoraApi::createTransaction
* @covers Islandora\Chullo\FedoraApi::prepareUri
* @covers Islandora\Chullo\FedoraApi::getBaseUri
* @covers Islandora\Chullo\FedoraApi::createTransaction
* @covers Islandora\Chullo\FedoraApi::generateTransactionUri
* @uses GuzzleHttp\Client
*/
public function testReturnsIdOn201()
Expand All @@ -28,12 +33,19 @@ public function testReturnsIdOn201()
$api = new FedoraApi($guzzle);
$client = new Chullo($api);

$this->assertEquals($client->getBaseUri(), 'http://localhost:8080/fcrepo/rest');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to cover getBaseUri. 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more concerned, that getBaseUri is already covered so either this is not a concern anymore or you have un-covered it. Maybe you need a rebase?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay. Now codecov is 404'ing on all the commits related to this PR.


$result = $client->createTransaction();
$this->assertSame($result, "tx:abc-123");
}
/**
* @covers Islandora\Chullo\Chullo::createTransaction
* @covers Islandora\Chullo\Chullo::getBaseUri
* @covers Islandora\Chullo\FedoraApi::createTransaction
* @covers Islandora\Chullo\FedoraApi::prepareUri
* @covers Islandora\Chullo\FedoraApi::getBaseUri
* @covers Islandora\Chullo\FedoraApi::createTransaction
* @covers Islandora\Chullo\FedoraApi::generateTransactionUri
* @uses GuzzleHttp\Client
*/
public function testReturnsNullOtherwise()
Expand Down