Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up composer configuration #68

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Clean up composer configuration #68

merged 1 commit into from
Apr 13, 2017

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Apr 13, 2017

Add scripts section with test and check scripts.
Remove redundant travis configuration
Add phpcpd to the -dev dependencies

See similar PR at: Islandora/Crayfish#25

What does this Pull Request do?

This does not change any code. It only changes the Composer and Travis-CI configurations, making it easier to test code. This also removes some redundant configuration in .travis.yml.

What's new?

There are two noteworthy changes to composer.json beyond the addition of the test and check scripts, namely the addition of a -dev dependency on phpcpd (which travis is expecting anyway) and it aligns the versions of phpunit and php_codesniffer to the versions defined in the Crayfish* repositories.

How should this be tested?

In the root of this repository, run composer test.

Additional Notes:

See here for more information: https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands

Interested parties

@Islandora-CLAW/committers

Add scripts section with test and check scripts.
Remove redundant travis configuration
Add phpcpd to the -dev dependencies
@codecov
Copy link

codecov bot commented Apr 13, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     93.63%   93.63%           
- Complexity        0       24   +24     
=========================================
  Files             3        3           
  Lines           110      110           
=========================================
  Hits            103      103           
  Misses            7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90c9f1...1651044. Read the comment docs.

@ruebot ruebot merged commit 9d198ca into master Apr 13, 2017
@ruebot ruebot deleted the composer_scripts branch April 13, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants