Update dependencies

[whikloj]

What does this Pull Request do?

Makes the __construct function private, so you must use the create method. We need to start storing the base_uri in our FedoraApi instance as Guzzle is deprecating access to the getConfig() method. So passing in a pre-built Guzzle will no longer allow us to determine the base_uri.

That is why this PR is against the new 2.x branch as this will be a backwards breaking change.

• Related GitHub Issue: Separate EntityMapper from Crayfish-Commons documentation#2220

*** This PR is FIRST in the chain of work ***

Dependant PRs:

• Upgrade 5.4 symfony and pull out EntityMapper Crayfish-Commons#63
• Upgrade symfony to 5.4 & separate EntityMapper Crayfish#174
• Remove dependency on Crayfish-Commons islandora#936
• Upgrade 5.4 symfony and separate EntityMapper Islandora-Devops/islandora-playbook#263

What's new?

1. Makes constructor private as described above
2. Changes in Github Actions to support Node16
3. Replaces Mockery with mock-webserver as we can't mock Guzzle response anymore so we needed a different way to test, hence mock-webserver.
4. Adds type hinting
5. Moves the tests into their own separate namespace.

• Does this change add any new dependencies? no
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? yes, if it passes in a pre-built Guzzle

How should this be tested?

This has no real change in functionality, but there are dependant PRs that will be listed above.

Documentation Status

• Does this change existing behaviour that's currently documented? no
• Does this change require new pages or sections of documentation? no
• Who does this need to be documented for?
• Associated documentation pull request(s): ___ or documentation issue ___

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +5.19 🎉

Comparison is base (42a35da) 94.80% compared to head (21b25fb) 100.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##                2.x       #99      +/-   ##
=============================================
+ Coverage     94.80%   100.00%   +5.19%     
  Complexity       20        20              
=============================================
  Files             2         1       -1     
  Lines            77       111      +34     
=============================================
+ Hits             73       111      +38     
+ Misses            4         0       -4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[seth-shaw-asu]

@whikloj , step 1 complete. What's next?

[whikloj]

We need to tag a 2.0.0 release of Chullo. I'll create a 1.0.0 release of https://github.com/Islandora/islandora-fedora-entity-mapper. Then I'll update the other PRs where necessary.

[whikloj]

Actually, maybe you should test Islandora/Crayfish#174 and Islandora/islandora#936 before I start cutting versions of https://github.com/Islandora/islandora-fedora-entity-mapper

[seth-shaw-asu]

Weren't those included in Islandora-Devops/islandora-playbook#263? That is what I used to test, so they should be ready to approve, although the islandora one will need composer.json references updated, right?

[whikloj]

Yes...I guess I'm just being paranoid. Okay, so I'll tag a 1.0.0 release of the entity mapper.

[whikloj]

Actually I have no permissions on https://github.com/Islandora/islandora-fedora-entity-mapper so if someone could setup the committer teams to have access please.

[whikloj]

I tagged a 2.0.0 release of chullo though

[seth-shaw-asu]

@whikloj , I just added the committers as maintainers on the repo, so you should be able to tag the release now.