Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump geolocation version #22

Merged
merged 3 commits into from
May 10, 2019
Merged

bump geolocation version #22

merged 3 commits into from
May 10, 2019

Conversation

seth-shaw-unlv
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv commented Apr 9, 2019 •
edited
Loading

GitHub Issue: Islandora/documentation#1077

What does this Pull Request do?

Bumps the Drupal geolocation module up from the now unsupported version, 2.0, to the new supported version, 3.0.0-rc1.

What's new?

  • Bumps geolocation version in composer.json

How should this be tested?

  1. Clone Claw Playbook
  2. Update inventory/vagrant/group_vars/webserver/drupal.yml: change islandora/islandora_demo:dev-8.x-1.x to islandora/islandora_demo:dev-issue-1077 (This will target the controlled access terms branch with the new geolocation module version.)
  3. vagrant up
  4. Check to ensure geolocation is now version 8.x-3.0-rc1.
  5. Play with Geographic Location taxonomy terms to make sure it works. E.g.
    1. I added a Las Vegas term with the appropriate latitude and longitude,
    2. I enabled the Geolocation Leaflet submodule
    3. I configured the Geographic Location vocabulary's display mode to use the Leaflet map
    4. Viewing the Las Vegas term successfully displayed a map with a marker in the center of Las Vegas.

Interested parties

@Islandora-CLAW/committers and @kayakr

@seth-shaw-unlv seth-shaw-unlv added the good first issue Good for newcomers label Apr 9, 2019
dannylamb
dannylamb approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dannylamb dannylamb merged commit b89766d into 8.x-1.x May 10, 2019
@seth-shaw-unlv seth-shaw-unlv deleted the issue-1077 branch May 10, 2019 16:23
@seth-shaw-unlv seth-shaw-unlv mentioned this pull request May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seth-shaw-unlv @dannylamb