Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright notice #42

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Add copyright notice #42

merged 3 commits into from
Jan 10, 2020

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Islandora/documentation#1267

What does this Pull Request do?

Adds an COPYRIGHT file to go along with our GPL2 LICENSE file. We've supposed to have been doing this since the beginning to comply with GPL2, so here it is. The copyright assertion itself matches that of our MIT licensed offerings.

Interested parties

@Islandora/8-x-committers @manez

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj
Copy link
Member

whikloj commented Jan 8, 2020

@dannylamb I've noticed this error before, do you want to fix it here to get Travis to pass? It looks like either you can keep it as an array and make it $delimiters or make it private const DELIMITERS

@dannylamb
Copy link
Contributor Author

I'll take a look 👨‍🔧

@seth-shaw-unlv seth-shaw-unlv merged commit 50c7537 into 8.x-1.x Jan 10, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the copyright-notice branch January 10, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants