Added form and view for authority link in resource types taxonomy #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ms_defaults/config/install/core.entity_form_display.taxonomy_term.resource_types.default.yml
Show resolved
Hide resolved
...ms_defaults/config/install/core.entity_view_display.taxonomy_term.resource_types.default.yml
Show resolved
Hide resolved
field_authority_link in resource_types taxonomy view and form
bseeger
commented
May 7, 2020
..._terms_defaults/config/install/field.storage.taxonomy_term.field_external_authority_link.yml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1499
Release pull requests, etc.)
What does this Pull Request do?
Completes the entity view and form view for the Resource Type taxonomy. This also cleans up the resource_types taxonomy a little in making it use the existing field_authority_link, rather then field_external_authority_link as it was doing. (this was done at the request of @seth-shaw-unlv and removes the need for the extra not-really-needed field and subsequent db table).
@seth-shaw-unlv - how does this look? I tried it and got the expected form setup now, though I do wonder if langcode, translation, and path should be in the form file.
When I did run this the first time the external authority link field was empty - which I suspect would be expected since the form was wrong before? Ie, there were defaults, but since the form wasn't set the defaults didn't get set? When I added data to the external authority link field, it did stick around as expected.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers