Fix validate check #77
Conversation
Empty strings are now always prohibited and checking
for intervals does not error if a non-interval
value is given.
Previously:
```php
use Drupal\controlled_access_terms\EDTFUtils;
EDTFUtils::validate("", TRUE, TRUE, TRUE);
// yields [];
EDTFUtils::validate("", FALSE, TRUE, TRUE);
// yields [ "Could not parse the date ''." ]
EDTFUtils::validate("1985-04-12T23:20:30Z", TRUE, TRUE, TRUE);
// yields [ "Date intervals cannot include times." ]
```
Now:
```php
use Drupal\controlled_access_terms\EDTFUtils;
EDTFUtils::validate("", TRUE, TRUE, TRUE);
// yields [ "Cannot parse empty value." ];
EDTFUtils::validate("", FALSE, TRUE, TRUE);
// yields [ "Cannot parse empty value." ];
EDTFUtils::validate("1985-04-12T23:20:30Z", TRUE, TRUE, TRUE);
// yields [ ]
```
|
Happy to review, although it probably won't be until tomorrow. In the mean-time we need to address those failing builds. I know we recently saw this on other repos, but I don't recall what changes we made to the github actions config to fix it. |
|
You need to uninstall mysql-client and mysql-common before trying to install it. |
|
@nigelgbanks, my last day at work before paternity leave is this Friday. Could you make the build changes before then so I can merge this before I check-out for a few weeks? |
|
Tried to apply the changes that @whikloj suggested and it got past the MySQL installation, but now just hangs on the |
|
@seth-shaw-unlv & @whikloj for this to get fixed this other pull must be first merged: I've tested it on a my own fork (which is passing): After that has been merged you'll have to manually rerun the Github Actions in the pull request. |
Fixes validation in two small cases
Empty strings are now always prohibited and checking
for intervals does not error if a non-interval
value is given.
Previously:
Now: