Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playbook fails on drupal-console; geerlingguy has deprecated #1599

Closed
rosiel opened this issue Aug 31, 2020 · 5 comments
Closed

Playbook fails on drupal-console; geerlingguy has deprecated #1599

rosiel opened this issue Aug 31, 2020 · 5 comments

Comments

@rosiel
Copy link
Member

rosiel commented Aug 31, 2020

The playbook fails.

Tracking down discussion on slack (thanks @mjordan and @elizoller !!) to why Drupal Console breaks the playbook:

Since Aug 17, https://drupalconsole.com/installer is no longer working. Issue: hechoendrupal/drupal-console#4262 Suggestion was to use Composer to require Drupal Console.

We get drupal console through Geerlingguy's role. https://github.com/geerlingguy/ansible-role-drupal-console It is deprecated as of August 20, 2020. (#2020mood)

On Aug 25, "unknownterritory" posted how to composer require drupal console via ansible. Can we do this in the playbook? hechoendrupal/drupal-console#4262 (comment)

@mjordan
Copy link
Contributor

mjordan commented Sep 2, 2020

@rosiel, fix has been merged, OK to close?

@rosiel
Copy link
Member Author

rosiel commented Sep 9, 2020

Yahoo!

@rosiel rosiel closed this as completed Sep 9, 2020
@red7-soporte
Copy link

Greetings for all
Most of us new users use the playbook to install islandora 8 (https://github.com/Islandora-Devops/islandora-playbook). Changes made to the drupal.yml file works fine for the development version (islandora-playbook-dev), but Danny's playbook doesn't have the updates from here.

@rosiel
Copy link
Member Author

rosiel commented Sep 9, 2020

Thanks @red7-soporte !

Yes, the fix was applied to the dev branch. which we all thought was also the default branch of the islandora-playbook repo.

The fact that 'main' is now the default branch may have been an accident with a large-scale script that changed our default default branch name from master to main.

I think the intention is that

git clone https://github.com/Islandora-Devops/islandora-playbook
cd islandora-playbook
vagrant up

is supposed to work.

The main branch is 'pinned to' our release, but ... it should be possible to also spin up the release, and this is a change purely to the playbook/installation instructions. I therefore think we should apply this fix to 'main' as well (as any other branches that should be live).

@dannylamb @mjordan @elizoller (who posted about which branch should be default, back on Sept 1, in slack).

@rosiel rosiel reopened this Sep 9, 2020
@red7-soporte
Copy link

Hi!
I tested the last updates in https://github.com/Islandora-Devops/islandora-playbook , all works fine!. Thanks
to all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants