-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on geerlingguy drupal console ansible role because … #186
Conversation
…composer installs it just fine
I'll smoke test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this on CentOS 7 hits an error with this addition:
TASK [webserver-app : Add project's /vendor/bin to $PATH] **********************
Tuesday 01 September 2020 08:54:29 -0700 (0:00:04.522) 0:24:15.422 *****
fatal: [default]: FAILED! => {"changed": false, "msg": "Destination /home/vagrant/.profile does not exist !", "rc": 257}
is there a centos equivalent? |
I think it is |
Of course, now I have a separate VM running right now, so I can't check at the moment. Give me a few minutes. |
no worries |
Yup, |
ok, i'll add a conditional for the two options |
I started building an ubuntu box earlier this morning before @elizoller pushed 470e3de (built successfully) so I'll start over with the latest changes. |
I've pulled in the updates and am running it again. |
Heh, okay, I initially said 'bash.profile' but then said 'Yep, |
agh sorry |
Giving it one more centos spin-up while I grab lunch. @mjordan want me to spin up an ubuntu as well or are you okay with the recent changes? |
Am in the middle of spinning up an ubuntu box now with the most recent changes. Will report back when it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CentOS 7 is 👍
Ubuntu is also 👍 |
I'm happy to merge if everyone is ready! |
Thanks for fixing this @elizoller! |
…composer installs it just fine
GitHub Issue: (Islandora/documentation#1599)
What does this Pull Request do?
Removes dependency on geerlingguy ansible role for drupal console
What's new?
Depending on composer for installing drupal console
How should this be tested?
Pull in this PR
run
ISLANDORA_DISTRO="ubuntu/bionic64" vagrant up
let it build and make sure you have a drupal installation
ssh in
vagrant ssh
and make sure you can run adrupal
commandAdditional Notes
I didn't test this on centos, so it probably should be
Interested parties
@Islandora-Devops/committers