Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on geerlingguy drupal console ansible role because … #186

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

elizoller
Copy link
Member

@elizoller elizoller commented Sep 1, 2020

…composer installs it just fine

GitHub Issue: (Islandora/documentation#1599)

What does this Pull Request do?

Removes dependency on geerlingguy ansible role for drupal console

What's new?

Depending on composer for installing drupal console

How should this be tested?

Pull in this PR
run ISLANDORA_DISTRO="ubuntu/bionic64" vagrant up
let it build and make sure you have a drupal installation
ssh in vagrant ssh and make sure you can run a drupal command

Additional Notes

I didn't test this on centos, so it probably should be

Interested parties

@Islandora-Devops/committers

@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

I'll smoke test this.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this on CentOS 7 hits an error with this addition:

TASK [webserver-app : Add project's /vendor/bin to $PATH] **********************
Tuesday 01 September 2020  08:54:29 -0700 (0:00:04.522)       0:24:15.422 ***** 
fatal: [default]: FAILED! => {"changed": false, "msg": "Destination /home/vagrant/.profile does not exist !", "rc": 257}

@elizoller
Copy link
Member Author

is there a centos equivalent?

@seth-shaw-unlv
Copy link
Contributor

I think it is ~/bash.profile.

@seth-shaw-unlv
Copy link
Contributor

Of course, now I have a separate VM running right now, so I can't check at the moment. Give me a few minutes.

@elizoller
Copy link
Member Author

no worries

@seth-shaw-unlv
Copy link
Contributor

Yup, ~/.bash_profile is what you need.

@elizoller
Copy link
Member Author

ok, i'll add a conditional for the two options

@elizoller
Copy link
Member Author

@seth-shaw-unlv see 9841a94

@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

I started building an ubuntu box earlier this morning before @elizoller pushed 470e3de (built successfully) so I'll start over with the latest changes.

@seth-shaw-unlv
Copy link
Contributor

I've pulled in the updates and am running it again.

@seth-shaw-unlv
Copy link
Contributor

Heh, okay, I initially said 'bash.profile' but then said 'Yep, ~/.bash_profile' implying that the first statement was correct while giving a different answer. Anyway, it is ~/.bash_profile, NOT ~/bash.profile. 🤦‍♂️

@elizoller
Copy link
Member Author

agh sorry

@seth-shaw-unlv
Copy link
Contributor

Giving it one more centos spin-up while I grab lunch. @mjordan want me to spin up an ubuntu as well or are you okay with the recent changes?

@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

Am in the middle of spinning up an ubuntu box now with the most recent changes. Will report back when it's done.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CentOS 7 is 👍

@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

Ubuntu is also 👍

@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

I'm happy to merge if everyone is ready!

@mjordan mjordan merged commit 809ba7d into Islandora-Devops:dev Sep 1, 2020
@mjordan
Copy link
Contributor

mjordan commented Sep 1, 2020

Thanks for fixing this @elizoller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants