Update Islandora for Drupal 9.x

[kayakr]

Report from Upgrade Status 3.0.0:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
islandora
Scanned on Fri, 06/11/2020 - 12:18.

27 errors found. 15 warnings found. Avoid some manual work by using
drupal-rector for fixing issues automatically or Upgrade Rector to generate
patches.

web/modules/contrib/islandora/modules/islandora_iiif/src/Plugin/views/style/IIIF
Manifest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 302  │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Controller/ManageMembersController.php:
┌─────────┬──────┬─────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                           │
├─────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Fix now │ 133  │ Call to deprecated method getLowercaseLabel() of class      │
│         │      │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in       │
│         │      │ drupal:8.8.0 and is removed from drupal:9.0.0. Instead, you │
│         │      │ should call getSingularLabel(). See                         │
│         │      │ https://www.drupal.org/node/3075567                         │
│         │      │                                                             │
└─────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/EventGenerator/EmitEvent.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 124  │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 144  │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 165  │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Flysystem/Adapter/FedoraAdapter.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 147  │ Call to deprecated function GuzzleHttp\Psr7\parse_header(): │
│ manually │      │ parse_header will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Header::parse instead.                                      │
│          │      │                                                             │
│ Check    │ 354  │ Call to deprecated function GuzzleHttp\Psr7\parse_header(): │
│ manually │      │ parse_header will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Header::parse instead.                                      │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/GeminiLookup.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 139  │ Call to deprecated function GuzzleHttp\Psr7\parse_header(): │
│ manually │      │ parse_header will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Header::parse instead.                                      │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/IslandoraUtils.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 93   │ Parameter $entity_query of method                            │
│         │      │ Drupal\islandora\IslandoraUtils::__construct() has typehint  │
│         │      │ with deprecated class Drupal\Core\Entity\Query\QueryFactory. │
│         │      │ Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. │
│         │      │ Use \Drupal\Core\Entity\EntityStorageInterface::getQuery()   │
│         │      │ or                                                           │
│         │      │ \Drupal\Core\Entity\EntityStorageInterface::getAggregateQuer │
│         │      │ y() instead.                                                 │
│         │      │                                                              │
│ Fix now │ 588  │ Call to deprecated method url() of class                     │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in            │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use    │
│         │      │ toUrl() instead.                                             │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/MediaSource/MediaSourceService.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now  │ 83   │ Parameter $entity_query of method                            │
│          │      │ Drupal\islandora\MediaSource\MediaSourceService::__construct │
│          │      │ () has typehint with deprecated class                        │
│          │      │ Drupal\Core\Entity\Query\QueryFactory. Deprecated in         │
│          │      │ drupal:8.3.0 and is removed from drupal:9.0.0. Use           │
│          │      │ \Drupal\Core\Entity\EntityStorageInterface::getQuery() or    │
│          │      │ \Drupal\Core\Entity\EntityStorageInterface::getAggregateQuer │
│          │      │ y() instead.                                                 │
│          │      │                                                              │
│ Fix with │ 296  │ Call to deprecated constant FILE_CREATE_DIRECTORY:           │
│ rector   │      │ Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. │
│          │      │ Use Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.  │
│          │      │                                                              │
│ Fix with │ 296  │ Call to deprecated constant FILE_MODIFY_PERMISSIONS:         │
│ rector   │      │ Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. │
│          │      │ Use                                                          │
│          │      │ Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.    │
│          │      │                                                              │
│ Fix with │ 296  │ Call to deprecated function file_prepare_directory().        │
│ rector   │      │ Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. │
│          │      │ Use                                                          │
│          │      │ Drupal\Core\File\FileSystemInterface::prepareDirectory().    │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Plugin/Action/AbstractGenerateDerivative.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 130  │ Call to deprecated function file_default_scheme().           │
│         │      │ Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. │
│         │      │ Use \Drupal::config('system.file')->get('default_scheme')    │
│         │      │ instead.                                                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Plugin/Action/EmitFileEvent.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 102  │ Call to deprecated method uriScheme() of class               │
│         │      │ Drupal\Core\File\FileSystemInterface. Deprecated in          │
│         │      │ drupal:8.8.0 and is removed from drupal:9.0.0. Use           │
│         │      │ Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::get │
│         │      │ Scheme() instead.                                            │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Plugin/Condition/FileUsesFilesystem.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 154  │ Call to deprecated method uriScheme() of class               │
│         │      │ Drupal\Core\File\FileSystemInterface. Deprecated in          │
│         │      │ drupal:8.8.0 and is removed from drupal:9.0.0. Use           │
│         │      │ Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::get │
│         │      │ Scheme() instead.                                            │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/src/Plugin/Field/FieldFormatter/IslandoraImageForm
atter.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now  │ 99   │ Call to deprecated method getStorage() of class              │
│          │      │ Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 │
│          │      │ and is removed from drupal:9.0.0. Use                        │
│          │      │ Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()  │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 127  │ Call to deprecated method urlInfo() of class                 │
│ rector   │      │ Drupal\Core\Entity\EntityInterface. Deprecated in            │
│          │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use           │
│          │      │ Drupal\Core\Entity\EntityInterface::toUrl() instead.         │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Functional/AddMediaToNodeTest.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 15   │ Usage of deprecated trait                                    │
│         │      │ Drupal\field\Tests\EntityReference\EntityReferenceTestTrait  │
│         │      │ in class                                                     │
│         │      │ Drupal\Tests\islandora\Functional\AddMediaToNodeTest.        │
│         │      │ Deprecated in drupal:8.6.2 and is removed from drupal:9.0.0. │
│         │      │ Use Drupal\Tests\field\Traits\EntityReferenceTestTrait       │
│         │      │ instead.                                                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Functional/IslandoraImageFormatterTest.p
hp:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 37   │ Call to deprecated function entity_get_display(). Deprecated │
│ rector   │      │ in drupal:8.8.0 and is removed from drupal:9.0.0. Use        │
│          │      │ EntityDisplayRepositoryInterface::getViewDisplay() instead.  │
│          │      │                                                              │
│ Fix now  │ 84   │ Call to deprecated method url() of class                     │
│          │      │ Drupal\Core\Entity\EntityInterface. Deprecated in            │
│          │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use    │
│          │      │ toUrl() instead.                                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Functional/LinkHeaderTest.php:
┌─────────┬──────┬───────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                          MESSAGE                          │
├─────────┼──────┼───────────────────────────────────────────────────────────┤
│ Fix now │ 138  │ Call to deprecated method url() of class                  │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in         │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use │
│         │      │ toUrl() instead.                                          │
│         │      │                                                           │
│ Fix now │ 142  │ Call to deprecated method url() of class                  │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in         │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use │
│         │      │ toUrl() instead.                                          │
│         │      │                                                           │
└─────────┴──────┴───────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Functional/MediaSourceUpdateTest.php:
┌─────────┬──────┬───────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                          MESSAGE                          │
├─────────┼──────┼───────────────────────────────────────────────────────────┤
│ Fix now │ 87   │ Call to deprecated method getUsername() of class          │
│         │      │ Drupal\Core\Session\AccountInterface. Deprecated in       │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\Core\Session\AccountInterface::getAccountName() or │
│         │      │ \Drupal\user\UserInterface::getDisplayName() instead.     │
│         │      │                                                           │
│ Fix now │ 96   │ Call to deprecated method getUsername() of class          │
│         │      │ Drupal\Core\Session\AccountInterface. Deprecated in       │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\Core\Session\AccountInterface::getAccountName() or │
│         │      │ \Drupal\user\UserInterface::getDisplayName() instead.     │
│         │      │                                                           │
│ Fix now │ 107  │ Call to deprecated method getUsername() of class          │
│         │      │ Drupal\Core\Session\AccountInterface. Deprecated in       │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\Core\Session\AccountInterface::getAccountName() or │
│         │      │ \Drupal\user\UserInterface::getDisplayName() instead.     │
│         │      │                                                           │
│ Fix now │ 119  │ Call to deprecated method getUsername() of class          │
│         │      │ Drupal\Core\Session\AccountInterface. Deprecated in       │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\Core\Session\AccountInterface::getAccountName() or │
│         │      │ \Drupal\user\UserInterface::getDisplayName() instead.     │
│         │      │                                                           │
│ Fix now │ 122  │ Call to deprecated method url() of class                  │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in         │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use │
│         │      │ toUrl() instead.                                          │
│         │      │                                                           │
└─────────┴──────┴───────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Functional/ViewModeAlterReactionTest.php:
┌─────────┬──────┬───────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                          MESSAGE                          │
├─────────┼──────┼───────────────────────────────────────────────────────────┤
│ Fix now │ 67   │ Call to deprecated method url() of class                  │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in         │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use │
│         │      │ toUrl() instead.                                          │
│         │      │                                                           │
└─────────┴──────┴───────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/tests/src/Kernel/FedoraAdapterTest.php:
┌──────────┬──────┬───────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                          │
├──────────┼──────┼───────────────────────────────────────────────────────────┤
│ Check    │ 49   │ Call to deprecated function GuzzleHttp\Psr7\stream_for(): │
│ manually │      │ stream_for will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Utils::streamFor instead.                                 │
│          │      │                                                           │
│ Check    │ 98   │ Call to deprecated function GuzzleHttp\Psr7\stream_for(): │
│ manually │      │ stream_for will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Utils::streamFor instead.                                 │
│          │      │                                                           │
│ Check    │ 555  │ Call to deprecated function GuzzleHttp\Psr7\stream_for(): │
│ manually │      │ stream_for will be removed in guzzlehttp/psr7:2.0. Use    │
│          │      │ Utils::streamFor instead.                                 │
│          │      │                                                           │
└──────────┴──────┴───────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/islandora.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_image/islandora_image.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_core_feature/islandora_core_feat
ure.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_breadcrumbs/islandora_breadcrumb
s.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_text_extraction/islandora_text_e
xtraction.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_text_extraction_defaults/islando
ra_text_extraction_defaults.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_iiif/islandora_iiif.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_video/islandora_video.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/islandora/modules/islandora_audio/islandora_audio.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Refer #1241 Audit code for Drupal 9 compatibility

[elizoller]

I have some work towards this and can get a PR up in the next few days for at least some of it

[elizoller]

When I run the tests without --suppress-deprecations i get theme warnings like:

      1x: Theme functions are deprecated in drupal:8.0.0 and are removed from
    drupal:10.0.0. Use Twig templates instead of theme_features_listing(). See
    https://www.drupal.org/node/1831138
        1x in NodeHasTermTest::testNodeHasTerm from
    Drupal\Tests\islandora\Functional

      1x: Theme functions are deprecated in drupal:8.0.0 and are removed from
    drupal:10.0.0. Use Twig templates instead of theme_assignment_form(). See
    https://www.drupal.org/node/1831138
        1x in NodeHasTermTest::testNodeHasTerm from
    Drupal\Tests\islandora\Functional

      1x: Theme functions are deprecated in drupal:8.0.0 and are removed from
    drupal:10.0.0. Use Twig templates instead of theme_features_items(). See
    https://www.drupal.org/node/1831138
        1x in NodeHasTermTest::testNodeHasTerm from
    Drupal\Tests\islandora\Functional

but there are no theme_ functions in the islandora module at all - can i ignore these?

[elizoller]

When running code sniffer with drupal practice, there are many instances of lines that exceed the 80 character limit -
ie. 3 | WARNING | Line exceeds 80 characters; contains 244 characters
How would you like to proceed on these?
I should note these occur in README.md and CONTRIBUTING.md files

[elizoller]

Also, with regards to code sniffer, is it ok to remove unused variables? there are several complaints about that.

[dannylamb]

🦃 🦃 🦃

I'm totally ok with removing unused variables. And the .md files should be ignored, so I wouldn't worry about them: https://github.com/Islandora/islandora_ci/blob/main/travis_scripts.sh#L16

🦃 🦃 🦃

[elizoller]

ok - a few more code sniffer changes have been pushed to that PR

[elizoller]

can this be closed?