-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D9 islandora #809
D9 islandora #809
Conversation
…ssing variable doc comments
i think this is ready for a review now. let me know of anything i missed or incorrectly fixed. |
i think the dependencies are now failing due to : |
modules/islandora_image/src/Plugin/Action/GenerateImageDerivativeFile.php
Outdated
Show resolved
Hide resolved
This has got to be in the running for most commits on a single islandora PR 😄 Thanks so much for all of this work, @elizoller ! |
…g to support old methods
… less duplicated code
We are green. Let's do this! |
Ticket: Islandora/documentation#1680
THIS PR depends on #816
What does this Pull Request do?
Updates Islandora Core for Drupal 9 support
What's new?
How should this be tested?
Checkout the PR
Do a cache clear
Make sure you can do normal islandora stuff - make a node/media/file and have them all persist to fedora properly, get derivatives, etc.
Pass all the tests
Note that updatedb must be run
Due to dependency chain, I think this will only work on a d9 site
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Interested parties
@Islandora/8-x-committers @kayakr @jordandukart