Github config: Require checks?

[rosiel]

In Chullo, the existing branch protection rules "Required checks" but no checks were selected.

Should we select all the status checks that are available (including Codecov)?

In general, I would, but I'm not sure if there was a reason these were removed.

[rosiel]

@dannylamb, do you have any thoughts/history on what whether we should 'require checks' (and actually include the checks!) on this and other repos in github.org/Islandora?

[dannylamb]

For me coding standards is the big one. Test passing is like a 99% of the time should be required but occasionally there's gremlins type deal, so we can't be ultra strict on that one. Code coverage and other things are nice to have but def shouldn't be considered blockers.

…

On Wed, Oct 6, 2021 at 2:51 PM Rosie Le Faive ***@***.***> wrote: @dannylamb <https://github.com/dannylamb>, do you have any thoughts/history on what whether we should 'require checks' (and actually include the checks!) on this and other repos in github.org/Islandora? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1909 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6PSH6POTAS3IBGBO7LW2LUFSEBZANCNFSM5FMNRP6Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[rosiel]

I added or ensured the all PHP build tests were listed as "required" in the new branch protection rules for:

Crayfish Commons
Islandora Defaults
Alpaca
Controlled Access Terms
JsonLD
Openseadragon
Syn
Crayfish

There are no checks configured for Migrate Islandora CSV.

[EDIT: I left codecov as not required, per @dannylamb's comment.]