Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow homarus to use faststart while converting videos #2162

Open
bibliophileaxe opened this issue Sep 8, 2022 · 1 comment
Open

Allow homarus to use faststart while converting videos #2162

bibliophileaxe opened this issue Sep 8, 2022 · 1 comment
Assignees
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@bibliophileaxe
Copy link

Overview of feature request
The current implementation of ffmpeg conversion does not use faststart, which enables videos to be played instantly. However, faststart does not work on fragmented videos and it also does not work with stdout pipes. In order to do this, we need to remove fragmentation and save the video as a tempfile. The response type would change from StreamedResponse to BinaryFileResponse which will delete the file after sending it.

What kind of user is the feature intended for?
User

What inspired the request?
There is a problem with playing large video files converted with Homarus on chrome. Because the videos are fragmented, chrome requests the moov atom of each fragment before playing these files causing multiple 206 partial content requests. It takes very long (>20 minutes) for large videos to start playing.

References:
https://stackoverflow.com/questions/64661989/chrome-video-tag-cant-play-fragmented-mp4-stream
https://gitlab.com/Shinobi-Systems/Shinobi/-/issues/237
https://gitlab.com/Shinobi-Systems/Shinobi/-/issues/66

What existing behavior do you want changed?
FFMPEG should use faststart instead of fragmentation

Any brand new behavior do you want to add to Islandora?
NA

Any related open or closed issues to this feature request?
NA

@bibliophileaxe bibliophileaxe added the Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) label Sep 8, 2022
@bibliophileaxe bibliophileaxe self-assigned this Sep 8, 2022
@bibliophileaxe bibliophileaxe moved this from Todo to In Progress in Islandora Issues Queue Sep 8, 2022
@rosiel
Copy link
Member

rosiel commented Oct 12, 2022

Merged Islandora/Crayfish#162 but there's a need for a version on Crayfish's 3.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants