Allow homarus to use faststart for video conversion

[bibliophileaxe]

GitHub Issue: (link)
Islandora/documentation#2162

• Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)
  https://stackoverflow.com/questions/64661989/chrome-video-tag-cant-play-fragmented-mp4-stream
  https://gitlab.com/Shinobi-Systems/Shinobi/-/issues/237
  https://gitlab.com/Shinobi-Systems/Shinobi/-/issues/66

What does this Pull Request do?

Replaces the moveflags frag_keyframe+empty_moov with faststart

A brief description of what the intended result of the PR will be and/or what problem it solves.
It allows videos to be played instantly on all browsers. On chrome large fragmented videos take too long to play.

What's new?

• Remove moveflags frag_keyframe+empty_moov
• Added moveflags faststart
• Converted file is saved as a tempfile - It is not possible to stream output with faststart.
• The response has changed from StreamResponse to BinaryFileResponse

How should this be tested?

• Ingest a large video file preferably mov and wait for derivative generation. Now try to play this file on chrome. There are multiple 206 partial content network requests and video starts playing after the moov atom for each fragment has been loaded.
• Now try the same with this PR. The video will start playing instantly.

Additional Notes:

Open to suggestions about alternate solutions but I've searched everywhere and couldn't find anything else that works.

Interested parties

@Islandora/committers @Islandora/8-x-committers @adam-vessey @lutaylor @willtp87 @jordandukart

[jordandukart]

Some comments on the PR, in general as well the existing set of tests are failing due to the changes here.

[willtp87]

During the tech call there was agreement in principal to continue with this approach.

[ruebot]

Does this need a separate PR to port this over to 3.x?

[whikloj]

I think the plan is to move all the ffmpeg arguments to the islandora context like the other microservices. Just need to figure out an nice way to get them into people's context configs

[codecov]

Codecov Report

Base: 76.60% // Head: 73.05% // Decreases project coverage by -3.54% ⚠️

Coverage data is based on head (c3c345e) compared to base (277f48a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x     #162      +/-   ##
============================================
- Coverage     76.60%   73.05%   -3.55%     
+ Complexity      161      150      -11     
============================================
  Files             6        5       -1     
  Lines           654      605      -49     
============================================
- Hits            501      442      -59     
- Misses          153      163      +10     

Impacted Files	Coverage Δ
...d_dir/Homarus/src/Controller/HomarusController.php	84.84% <0.00%> (-15.16%)	⬇️
...d_dir/Houdini/src/Controller/HoudiniController.php

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nchiasson-dgi]

Ran tests against this PR using a large video file and it appears to perform as advertised, video file could be run immediately upon loading content display page.

[rosiel]

Discussion from the Tech Call:
Merging, but... as @ruebot said we should port this to 3.x, as that's where new development should be. (Hopefully it isn't too difficult with the move of Homarus to Symfony!) Per @whikloj 's comment, If we want to move all options into config within the Drupal Actions, that's great but shouldn't block this.

[ruebot]

I cribbed from this PR and have it over here in our fork of 3.x. There is .mov stuff in there as well.