Better thumbnails

[manez]

Currently, the thumnbails generated on ingest end up wonky if the original aspect ratio is too far from that of the thumbnail area. No idea how challenging that may be to fix, but it's a minor improvement worth noting.

[daniel-dgi]

This is a great issue. Currently the thumbnails are just a resizing of the image using CSS. Shameful, i know, but I had deadlines. Ideally, the sync machinery will call out to imagemagick a la https://github.com/daniel-dgi/fcrepo-camel-workshop/blob/master/06-ThumbnailGenerator.xml . It should also be added as a PCDM file with the ThumbnailImage use from https://github.com/duraspace/pcdm/blob/master/pcdm-ext/use.rdf

Would be a great place for someone to dive right into Camel and PCDM.

[ruebot]

@daniel-dgi 👍 -- possible newbie ticket too, right?

[daniel-dgi]

Newbie ticket if you're a developer, for sure.

[sprklinginfo]

@daniel-dgi try to get my head around on camel ... for fcrepo-camel-workshop link you put above, do you have presentation slides that I can check? or anything useful to check out for the 'camel on islandora land'? Something other than 'camel in action' book as probably I don't have time to go through a huge book 😄

[dmoses]

@sprklinginfo ... I'm wondering if you'd hook into Drupal's image style configs? They are here: http://localhost:8000/admin/config/media/image-styles and it would provide a flexible method for users to define their thumbnail sizes, etc.
I may be full of beans.

[daniel-dgi]

@sprklinginfo https://docs.google.com/a/fedora-commons.org/presentation/d/1uy1Yes_GmZAFuhc0u74FPHu0ALjWLsf9ffsxRW1I8CE/edit?usp=sharing

I'll have to figure out best thing to do with perms on that in the morning. For now, you should have an invite for read permissions on that.

At some point in time, we'll have to talk PCDM in order to add a file. Which means we'll have to talk LDP too :) http://islandora.ca/sites/default/files/images/It%E2%80%99s%20Dangerous%20to%20Go%20it%20Alone.pdf

[sprklinginfo]

@daniel-dgi Thanks! I will check out both slides.
@dmoses Sounds like a good idea.
@manez when you said "original aspect ratio is too far from that of the thumbnail area", Do you mean the original image is too big? It would be great if I can see a screenshot for that "wonky" thumbnail.

[manez]

Check out this example: http://future.islandora.ca/node/6

Thumbnails are being forced into a certain aspect ratio, regardless of the original, so a long thing image becomes short and squat.

[DiegoPino]

@sprklinginfo, currently the thumbnail is being build from the medium size and the height and width values (css, image is not resized) are being set here https://github.com/Islandora-Labs/islandora/blob/7.x-2.x/drupal/islandora_medium_size_service/include/islandora_medium_size_service.inc#L39-L45

My 2 Cents, i believe the size should be removed there,
as @dmoses correctly states, going the drupal way, this should/could be configured using the image-styles config page. To apply this you need to go to drupal land and enforce an 'image_style' instead of setting height and width. From there, it's up to defining a correct style using the admin and/or theming using templates. I hope this helps.