No RPM setup for ImageMagick in Crayfish

[ajs6f]

Trying to install from claw-playbook on CentOS7, I ran into

TASK [Islandora-Devops.crayfish : Install requisite package repositories] ******************************************************************
Tuesday 22 May 2018  10:22:35 -0400 (0:00:00.044)       0:22:23.769 ***********
fatal: [default]: FAILED! => {"changed": false, "module_stderr": "Shared connection to [SI hostname] closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/tmp/ansible_JZD1B4/ansible_module_apt_repository.py\", line 551, in <module>\r\n    main()\r\n  File \"/tmp/ansible_JZD1B4/ansible_module_apt_repository.py\", line 510, in main\r\n    if isinstance(distro, aptsources_distro.Distribution):\r\nNameError: global name 'aptsources_distro' is not defined\r\n", "msg": "MODULE FAILURE", "rc": 1}

which, IIUC, is coming from the fact that that task in oles/internal/Islandora-Devops.crayfish/tasks/install.yml has only a setup for apt-based and not RPM-based systems. I'm wondering whether the specific package of ImageMagick called out there important or can I use the stock packages for my system?

[seth-shaw-unlv]

My fork's centos branch uses the ansible "package" module (as opposed to either yum or apt specifically) to install the provided ImageMagick package.

I don't remember why I haven't created a PR on this yet. Perhaps it needed some cleanup? If that branch works for you I will go ahead and issue the PR.

[ajs6f]

@seth-shaw-unlv Awesome! I will test that branch and report back here (might not be until tomorrow).

[ajs6f]

Cha-ching! @seth-shaw-unlv 's branch worked to get me past this. Thanks! Should I close it or leave it open until his PR is merged?

[seth-shaw-unlv]

Might as well leave it open until the new PR is merged.

[seth-shaw-unlv]

Oh, wait, there is a PR already. It looks like it got side-tracked by other discussions. (I'm looking at you Gemini #828. See also Crayfish issue 2.)

[ajs6f]

Urg, #828 was my fault, sorry! @seth-shaw-unlv just keeps solving my problems as fast as I can find them!

[seth-shaw-unlv]

No, it isn't you @ajs6f; we've just procrastinated actually fixing this piece.

[dannylamb]

@ajs6f @seth-shaw-unlv is there anything you need to move islandora-deprecated/ansible-role-crayfish#3 along? if it's been tested and works, i'm inclined to just pull it in.

[ajs6f]

I tried it and it worked for me on CentOS7.

[seth-shaw-unlv]

@dannylamb islandora-deprecated/ansible-role-crayfish#3 itself works fine, once you get past the Gemini error. We just hadn't had many testers because of that hurdle.

@DigitLib made some suggestions for improvement (regarding tesseract and httpd.cnf) but they haven't been incorporated into the PR. We could just merge it as is and make a new issue based on @DigitLib's suggestions.

[dannylamb]

@seth-shaw-unlv I'll pull the trigger if there's no objections from @DigitLib

[DigitLib]

@dannylamb @seth-shaw-unlv we can also define an additional languages to install with tesseract by default (French, Italian, Serbian....) adding it in /vars/RedHat.yml
tesseract-langpack-fra
tesseract-langpack-ita
tesseract-langpack-srp
...?

[seth-shaw-unlv]

@DigitLib, that is fine by me. Let's just do it as a separate ticket and PR, if that is okay.

[DigitLib]

@seth-shaw-unlv Okay great. And to make a little add in README how to install additional language in CentOS (sudo yum install tesseract-langpack-ger for example)

[DigitLib]

@seth-shaw-unlv tested langpack addition in /var/RedHat.yml it works! installed!

[seth-shaw-unlv]

Resolved by islandora-deprecated/ansible-role-crayfish/pull/3