-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
install tesseract and imagemagick Use variables for apache config dirs
The previous source .tgz disappeared when a new version appeared, but the github version sticks around. Replacing the gzipped source sith github clone for stability.
defaults/main.yml
Outdated
@@ -1,12 +1,12 @@ | |||
crayfish_user: www-data | |||
crayfish_user: "{% if ansible_os_family == 'RedHat' %}apache{% else %}www-data{% endif %}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can, I'd like to have the variables work like we were talking about in islandora-deprecated/ansible-role-karaf#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that once the Karaf PR is put to bed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaults/main.yml
Outdated
tesseract_lang_dir: /usr/local/share/tessdata/ | ||
tesseract_directory: "/opt/tesseract-{{ tesseract_version }}" | ||
|
||
httpd_conf_directory: "{% if ansible_os_family == 'RedHat' %}/etc/httpd{% else %}/etc/apache2{% endif %}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
tasks/install.yml
Outdated
@@ -1,8 +1,18 @@ | |||
--- | |||
|
|||
- name: Install requisite package repositories | |||
- include: tesseract-centos.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kind of worried about adding this here and I'm wondering if we would be better off moving tesseract to its own role. It could install the package for Debian, and do the compile for Cent. I don't think it would be too much work to move the tesseract stuff out of this role, and put it into its own.
Seems like a bit of a mixing of concerns the way it is right now, since the yml for compiling tesseract is ~100 lines, and the yml for installing crayfish is ~70 lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. I'll need someone to make the repo since I don't have write permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to start it in your own GitHub, we can transfer it over afterwords. @dannylamb should be able to help with the transfer process when the role is ready...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seth-shaw-unlv Let me know when you're ready and I can set up the transfer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannylamb Just published the new tesseract-ocr repository. Tested with both Debian and CentOS. Once this is moved over to Islandora-DevOps we can make a PR to update claw-playbook's requirements.yml and crayfish.yml.
@jonathangreen @dannylamb are we good with this one now? |
This worked with Ubuntu but with Centos I fail at
|
@whikloj That is a problem with the tomcat role. Which tomcat role version do you have? |
@whikloj Update your requirements.yml:
|
Sorry @seth-shaw-unlv I totally lost track of this one. I can take a look next week if @whikloj doesn’t get to it first. |
@seth-shaw-unlv ugh you're right so we need Islandora-Devops/islandora-playbook#60 merged and then fcrepo-syn breaks because of https://github.com/Islandora-Devops/ansible-role-fcrepo-syn/issues/4 🤦♂️ I'm gonna pull you in there to move this along. |
@whikloj I thought Islandora-Devops/islandora-playbook#60 resolves Islandora-Devops/ansible-role-fcrepo-syn#4 by overriding the fcrepo-syn defaults. We shouldn't need another PR to fix it. What happened when you tested Islandora-Devops/islandora-playbook#60? |
@seth-shaw-unlv ok, so I have got the new claw-playbook master with Islandora-Devops/islandora-playbook#60 merged, then I altered.
Ran
Now I am getting to crayfish with centos but hitting this.
|
In /vars/RedHat.yml can be added tesseract after ImageMagick to be installed |
@DigitLib I'm feeling foolish now. When I was looking around for information about tesseract and CentOS I saw mention that tesseract was only in epel-testing. I neglected to check the epel repo myself. Indeed, it has been in the main epel repo since 2016! |
So, we've been using remi for PHP 7 in webserver.yml and we haven't been using EPEL (which makes me feel a bit better about not catching it). Do we want to start using EPEL for PHP 7 instead, so we get access to tesseract as well? |
@seth-shaw-unlv I checked a EPEL repo package list and I didn't find a PHP 7 there http://mirror.airenetworks.es/epel/7/x86_64/Packages/p/ and check also with yum install php70 it is only in remi-safe. EPEL is installed during installation process (I don't know exactly when). Let's stay with remi for PHP 7... |
Can we add new symlink as mentioned in httpd.cnf file:
Aftrer - name: Symlink crayfish httpd config file into action gruop? Or to find a clenear solution? |
@DigitLib, @ajs6f has tested this in https://github.com/Islandora-CLAW/CLAW/issues/831and it successfully works. I'm inclined to bring this code in to prevent it from going stale. Would you consider creating an additional issue (and possibly PR by the looks of it) for the symlink? |
@dannylamb Working on symlink... |
Fixes for issue #2