Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Addin a symlink for CentOS #6

Closed
wants to merge 1 commit into from
Closed

Addin a symlink for CentOS #6

wants to merge 1 commit into from

Conversation

DigitLib
Copy link
Contributor

As defined in an issue https://github.com/Islandora-Devops/ansible-role-crayfish/issues/5 to install in a CentOS defined additional config dir for Apache.
@dannylamb PR created

As defined in an issue https://github.com/Islandora-Devops/ansible-role-crayfish/issues/5 to install in a CentOS defined additional config dir for Apache
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I think we can make it cleaner. Instead of creating a separate task for CentOS, we can change the existing symlink task to use a variable (e.g. httpd_conf_directory_enabled) and set it in their respective vars configuration files (Debian.yml and RedHat.yml).

E.g. RedHat.yml would have the line:
httpd_conf_directory_enabled: "{{httpd_conf_directory}}/conf.d"
and the existing symlink task's dest line would read:
dest: "{{httpd_conf_directory_enabled}}/{{item}}.conf"

@DigitLib
Copy link
Contributor Author

@seth-shaw-unlv if there is a cleaner solution it would be good. I mention it in #3 (comment) . Can it be done in this PR or to create a new?
Great that works!

@seth-shaw-unlv
Copy link
Contributor

I'll leave it up to you @DigitLib, you can either update your PR, or we can close it and I can issue a new PR based on my fork testing the new solution.

@DigitLib
Copy link
Contributor Author

@seth-shaw-unlv great fork! :) I will close my PR

@DigitLib
Copy link
Contributor Author

Closed because @seth-shaw-unlv made a cleaner solution.

@DigitLib DigitLib closed this May 24, 2018
dannylamb pushed a commit that referenced this pull request Jun 6, 2018
* centos fixes

install tesseract and imagemagick
Use variables for apache config dirs

* removing debugging task

* Replace leptonica source tgz with git clone

The previous source .tgz disappeared when a new version appeared, but the github version sticks around. Replacing the gzipped source sith github clone for stability.

* removed tesseract-ocr install

* symlink httpd conf for centos

See review of /pull/6
@whikloj whikloj deleted the Symlink-for-CentOS branch March 24, 2020 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants