Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the documentation style guide #1342

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Updating the documentation style guide #1342

merged 4 commits into from
Nov 19, 2019

Conversation

manez
Copy link
Member

@manez manez commented Nov 18, 2019

GitHub Issue: #1040

What does this Pull Request do?

Moves the documentation style guide from the technical documentation section to the contributing section (I think it makes more sense there), and adds some guidelines, mostly based on the guidelines we documented for the current sprint.

What's new?

Deleted the old page, put it in a new spot, added some items.

How should this be tested?

Preview the document, see if it makes sense/is helpful as a guide for documentation contributors.

Interested parties

@Islandora/8-x-committers and @ysuarez

Removing style guide from tech docs to put it in contributing docs
Updates to the style guide
@manez manez mentioned this pull request Nov 19, 2019
@whikloj
Copy link
Member

whikloj commented Nov 19, 2019

@manez does this need a line in mkdocs.yml too?

@manez
Copy link
Member Author

manez commented Nov 19, 2019

@whikloj Indeed it does. I moved it to the new section in mkdocs.yml

mkdocs.yml Outdated
@@ -77,4 +76,5 @@ pages:
- 'Islandora 7': 'technical-documentation/migrate-7x.md'
- Contributing:
- 'How to contribute': 'contributing/CONTRIBUTING.md'
- 'Documentation Style Guide': 'technical-documentation/docs_style_guide.md'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path needs to be 'contributing/docs_style_guide.md'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀

🤦‍♀
Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit a9561ee into Islandora:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants