Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #1684

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Update PULL_REQUEST_TEMPLATE.md #1684

merged 1 commit into from
Nov 13, 2020

Conversation

manez
Copy link
Member

@manez manez commented Nov 10, 2020

Purpose / why

Depends on #1683 being merged first.

Adds another checkbox to look for an updated "last updated on." Technically, this is included under the second checkbox, "Does the proposed documentation align with the Islandora Documentation Style Guide?", but I think that since the date should be common to all docs pages and it's probably going to be something that's easy to overlook, it merits its own callout in the checklist.

What changes were made?

Added a new checkbox for reviewers.

Verification

I think preview and review should do it for this one.

Interested Parties

@Islandora/8-x-committers once the other PR is merged.


Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@manez manez marked this pull request as ready for review November 13, 2020 16:19
@manez
Copy link
Member Author

manez commented Nov 13, 2020

The Style Guide PR is in, so this is ready for review.

@rosiel rosiel merged commit c0eb756 into main Nov 13, 2020
@rosiel rosiel deleted the manez-template branch November 13, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants