Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource-nodes per doc sprint. #1844

Closed
wants to merge 3 commits into from
Closed

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jun 2, 2021

Purpose / why

"Local" (non-forked) PR so that we can use secret variables. This replaces #1841

Replace this text - Name some folks who may be interested, if documentation related mention @Islandora/documentation, or, if unsure, @Islandora/8-x-committers


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel
Copy link
Member Author

rosiel commented Jun 2, 2021

This PR was a test; see #1845 which will allow #1841 to pass.

@rosiel rosiel closed this Jun 2, 2021
@rosiel rosiel deleted the sprint-resource-nodes branch June 2, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant