Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACME External Account Binding Support #2096

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

misilot
Copy link
Contributor

@misilot misilot commented Apr 25, 2022

Purpose / why

Update Docs for ACME External Account Binding.

This can't be merged until Islandora-Devops/isle-dc#253 is merged, otherwise the feature doesn't exist.

What changes were made?

Add documentation for how to configure External Account Binding with ACME

Verification

Utilize an SSL Certificate provide that supports External Account Binding to request SSL Certificate. Verify you get SSL certificate from your provider, and not Let's Encrypt. A couple of options include InCommon and ZeroSSL.com

Interested Parties

@Islandora/documentation


Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Related Tickets

Islandora-Devops/isle-dc#253
Islandora-Devops/isle-dc#252
#2096

Adds documentation on configuring Traefik for External Account Binding
with ACME.
@rosiel rosiel merged commit 2161edf into Islandora:main Jan 3, 2023
@misilot
Copy link
Contributor Author

misilot commented Jan 3, 2023

@rosiel the PR that is needed for this still hasn't been merged Islandora-Devops/isle-dc#253

rosiel added a commit that referenced this pull request Jan 5, 2023
rosiel added a commit that referenced this pull request Jan 5, 2023
rosiel pushed a commit that referenced this pull request Jan 5, 2023
Adds documentation on configuring Traefik for External Account Binding
with ACME.
@rosiel
Copy link
Member

rosiel commented Jan 5, 2023

My bad! I've reverted, and re-opened it as a draft: #2199

rosiel added a commit that referenced this pull request Jan 13, 2023
Adds documentation on configuring Traefik for External Account Binding
with ACME.

Co-authored-by: Tom Misilo <1446856+misilot@users.noreply.github.com>
kstapelfeldt pushed a commit that referenced this pull request Jan 27, 2023
* ACME External Account Binding Support (#2096)

Adds documentation on configuring Traefik for External Account Binding
with ACME.

* Viewers updated to new method.

---------

Co-authored-by: Tom Misilo <1446856+misilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants