Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 002 Issue 211, documentation of micro services. #216

Merged
merged 2 commits into from
May 11, 2016
Merged

Sprint 002 Issue 211, documentation of micro services. #216

merged 2 commits into from
May 11, 2016

Conversation

br2490
Copy link

@br2490 br2490 commented Apr 30, 2016

This PR addresses documentation issue #211. See commit history for versioning of the document - 1) intial conversion 2) changing ports to reflect php microservices and added link to original document.

Also, @8282, whomever you are, please ignore this and my commit message ;) 👍 .

@br2490
Copy link
Author

br2490 commented Apr 30, 2016

and tagging @Islandora-CLAW/7-x-2-x-committers

@ruebot
Copy link
Member

ruebot commented Apr 30, 2016

Looks good to me.

@DiegoPino, @whikloj do you want to take it in as is, then start hacking at it? Or hack at it now, then take it in?

@whikloj
Copy link
Member

whikloj commented May 1, 2016

Sorry I must have missed this conversation. We have documentation as README.md files for each service in the services directory. Is this meant to bring that information into one location? 'Cause we'll have to maintain it in two places.

Top Level Services Directory
ResourceService
TransactionService
CollectionService

@DiegoPino
Copy link
Contributor

@whikloj, this goes into: docs/technical-documentation/islandora-middleware-services-api.md
i feel it's complimentary to each readme.md. @ruebot do you know if .md files allow includes, or can be generated from external ones? Maybe we could in the future split this into the individual readme files and then make a composite one (this one) in that feeds from them? That could solve your concern Jared?

@br2490
Copy link
Author

br2490 commented May 1, 2016

#211 was a task simply to copy-pasta the original by Danny to MD so it
could be worked on more actively. If Diego's suggestion is the way to go
++, but I'm afraid I might not know what to do in terms of linking or
transforming many docs to one.

On Sun, May 1, 2016 at 12:04 PM, Diego Pino Navarro <
notifications@github.com> wrote:

@whikloj https://github.com/whikloj, this goes into:
docs/technical-documentation/islandora-middleware-services-api.md
i feel it's complimentary to each readme.md. @ruebot
https://github.com/ruebot do you know if .md files allow includes, or
can be generated from external ones? Maybe we could in the future split
this into the individual readme files and then make a composite one (this
one) in that feeds from them? That could solve your concern Jared?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#216 (comment)

Benjamin Rosner

Instructional Applications Developer
Library and Academic Information Services
Sulzberger Hall Annex, Barnard College
p: 212-854-9005

@whikloj
Copy link
Member

whikloj commented May 2, 2016

@DiegoPino there doesn't seem to be any way to include the content (see issue here).

I don't want to create a long drawn out conversation over this. So you are welcome to merge this as is.

@ruebot
Copy link
Member

ruebot commented May 11, 2016

We'll sort this out as we sort through documentation in #182

@ruebot ruebot merged commit 18be740 into Islandora:sprint-002 May 11, 2016
@br2490 br2490 deleted the sprint-002-issue-211 branch May 12, 2016 17:41
@ruebot ruebot mentioned this pull request Jul 21, 2016
@ruebot
Copy link
Member

ruebot commented Jul 21, 2016

Related to #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants