Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker demo - update make command to match isle-dc #2179

Merged
merged 1 commit into from
Oct 12, 2022
Merged

docker demo - update make command to match isle-dc #2179

merged 1 commit into from
Oct 12, 2022

Conversation

phette23
Copy link
Contributor

@phette23 phette23 commented Oct 6, 2022

Purpose / why

Fix a small inconsistency—the make demo-install-profile command listed on this page won't work because there isn't a matching target in the isle-dc Makefile.

What changes were made?

Changed make demo-install-profile bash command to make demo.

Verification

Try pulling down the isle-dc repo and running both commands; only the latter one works.

Interested Parties

  • @Islandora/documentation

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel rosiel merged commit aaea0a4 into Islandora:main Oct 12, 2022
@phette23 phette23 deleted the mk-demo branch March 9, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants