Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content_types.md #2238

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Update content_types.md #2238

merged 2 commits into from
Jun 15, 2023

Conversation

joshdentremont
Copy link
Contributor

Updated instructions for new content types to include mandatory fields and to remove steps that are no longer necessary.

Purpose / why

It was not clear to me that the member of field was mandatory, but without it the nodes are not considered Islandora objects.

What changes were made?

Added info on mandatory fields (model and member of) to make it clear that both of those fields need to be included in any custom content types.

Also removed instructions for updating context that is no longer needed. Indexing happens on all nodes that are considered Islandora objects, and as long as they have the member of field they will be considered islandora objects.

Verification

Create a new content type with the member of field included. Add an object using that content type. Check that the object is in Fedora.

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Updated instructions for new content types to include mandatory fields and to remove steps that are no longer necessary.
@rosiel rosiel self-requested a review June 14, 2023 17:24
@rosiel rosiel merged commit e14abd1 into Islandora:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants