Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the running tests page. #2246

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Minor improvements to the running tests page. #2246

merged 1 commit into from
Jul 8, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jul 5, 2023

Purpose / why

The testing docs needed a bit of a tuneup.

What changes were made?

  • made a few things more explicit
  • improved the example to be more helpful by including default values

Verification

Can you follow it and get tests running?

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-08 18:30 UTC

@alxp alxp merged commit e45cedd into main Jul 8, 2023
@alxp alxp deleted the rosiel-patch-1 branch July 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants