Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL Aliases and Breadcrumbs docs. #2299

Merged
merged 3 commits into from
May 8, 2024
Merged

Add URL Aliases and Breadcrumbs docs. #2299

merged 3 commits into from
May 8, 2024

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 1, 2024

Purpose / why

We realized there was a big gap in our knowlege base around best practices for URL aliases. This opens up a space for those to be documented.

Hold off on merging until Islandora-Devops/islandora-starter-site#148 is merged . [Edit: it is now merged.]

What changes were made?

New page: URL Aliases.

Verification

Is the content sound?

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link

github-actions bot commented May 1, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-08 18:33 UTC

@rosiel rosiel marked this pull request as draft May 2, 2024 12:32
@rosiel
Copy link
Member Author

rosiel commented May 2, 2024

It seems pathauto breaks our breadcrumbs.

Edit: not true. The 404 error i was having recently (Islandora-Devops/islandora-starter-site#146 (comment)) was the culprit.

@rosiel rosiel marked this pull request as ready for review May 2, 2024 15:42
@rosiel rosiel changed the title Add URL Aliases doc. Add URL Aliases and Breadcrumbs docs. May 2, 2024
@rosiel
Copy link
Member Author

rosiel commented May 2, 2024

I accidentally include my other pull request in this one. It might be quicker to treat them as one, anyway.

@rosiel rosiel mentioned this pull request May 2, 2024
7 tasks
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed it in the documentation meeting today. Looks good!

@aOelschlager aOelschlager merged commit 9036b85 into main May 8, 2024
1 check passed
@joecorall joecorall deleted the pathauto branch May 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants