Deletion abstraction #1017
Merged
Deletion abstraction #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
reviewed
May 13, 2024
Fixed PHPDoc
|
This was an odd one - PHPStorm insisted that $media was an object, but gettype() disagreed. |
rosiel
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
What does this Pull Request do?
Abstracts duplicated code to a function in Utils
What's new?
The logic for media and file deletion has been moved from i
slandora_object_delete_form_submitandConfirmDeleteMediaAndFile::submitFormhas been moved toIslandoraUtils::deleteMediaAndFilesHow should this be tested?
Delete an Islandora node, with
Delete all associated medias and nodescheckedCheck to see that the media and files associated with that node have been deleted.
Select
Delete Media and File(s)from the Action menu and check to see that all expected deletions have occurred.Documentation Status
No change in use
Interested parties
@Islandora/committers @kayakr