Add configuration for a user and password to the broker. #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks straightforward and good. I'm juggling a few things right now but I'll get around to smoke testing this soon @jordandukart |
dannylamb
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
I've pulled this down and tested it pretty thoroughly. Works as advertised. Form fails if you don't add a password. If you've already entered a password and don't enter one, it uses the old one.
After setting up activemq to use basic auth, I could successfully connect to the broker and publish messages from Drupal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: Islandora/documentation#1454
What does this Pull Request do?
Adds user/password configuration for the broker such that non-anonymous connections can be made.
What's new?
Configuration form settings and passing down the credentials to the
islandora.stompservice.How should this be tested?
Configure ActiveMQ to require authentication.
Add those credentials to the form.
Things operate as expected.
Interested parties
@Islandora/8-x-committers