Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on #1549 and #1550. #782

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Work on #1549 and #1550. #782

merged 1 commit into from
Aug 26, 2020

Conversation

mjordan
Copy link

@mjordan mjordan commented Jun 25, 2020 •
edited
Loading

Github issues: Islandora/documentation#1549 and Islandora/documentation#1550.

What does this Pull Request do?

Adds bundle-to-RDF-Type mapping and multiple predicate values.

What's new?

For fields that are mapped to multiple properties, all are now showing up, not just the first. For bundles, their mapping to RDF Type are now displayed.

How should this be tested?

  1. Pull in this branch.
  2. Visit admin/reports/islandora/rdf_mappings
  3. Confirm that multi-property fields are showing all the expected mappings (e.g. "Name (name)" in the Audio media bundle)
  4. Confirm that bundle-to-RDF-Type mappings are showing up as expected next to the bundle names/labels like in this screenshot:

bundletype

Additional Notes:

  • Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? Yes, but only adds more information to an existing report.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Yes.

Interested parties

@kayakr, @Islandora/8-x-committers

@mjordan
Copy link
Author

mjordan commented Jul 31, 2020

@kayakr any chance you can confirm this PR addresses your comments?

@manez manez assigned elizoller and unassigned elizoller Aug 26, 2020
@manez manez requested a review from elizoller August 26, 2020 17:51
elizoller
elizoller approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed testing steps and worked as expected.

@elizoller elizoller merged commit cd1ff00 into Islandora:master Aug 26, 2020
This was referenced Aug 26, 2020
Closed
Closed
@mjordan mjordan mentioned this pull request Mar 11, 2021
Closed
@dannylamb dannylamb mentioned this pull request Apr 28, 2021
Merged
elizoller pushed a commit that referenced this pull request May 4, 2021
@dannylamb @mjordan
Mjordan issue 1521 redo (#835)
07178e9 
* Redo of and #778 and #782, which I opened and were merged against the master branch.

* Code style fix.

* Code style fix.

* Syntax error.

* Dep injecting services

* Coding standards

Co-authored-by: Mark Jordan <mjordan@sfu.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizoller elizoller elizoller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjordan @elizoller