Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Islandora/documentation#1731
What does this Pull Request do?
Removes
hook_post_action
as a dependency, and manually implements the functionality it was providing.The
hook_post_action
module likely won't be ported to Drupal 9. The functionality it provides is also being implemented in Drupal 9 at a later date. The intention of this pull request is to provide a stopgap between the loss of support forhook_post_action
in Drupal 9 and our eventual ability to recreate this functionality when it's added into core in Drupal 9.1 or later.What's new?
After an
insert
operation is taken for a Media, a registered shutdown function fires off file derivative actions for that Media.How should this be tested?
We only need to ensure that there is no regression from #756, so the test case there will suffice.
Additional Notes:
The recommendation in this PR is to wait for entity events to be implemented in D9, but also, if we did the work to implement actions as mentioned in this comment, said future work would likely be enough to delay us having to migrate completely to entity events. But I think those entity events should be considered the ideal endgame.
Interested parties
@dannylamb likely as part of the ongoing D9 sprint https://github.com/orgs/Islandora/projects/3