-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
captions v2 #826
captions v2 #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised! 👍
@elizoller I can now add a |
It's just using HTML5 for the player, so most modern browsers should handle it. I will look into it - what kind of audio file are you using? |
@elizoller The files I used are audio.mp3 and transcript.vtt from https://umd-mith.github.io/webvtt-player/annotations.html |
@kayakr i have finally had a chance to look into this with more detail and discovered that, as far as i can tell, the HTML5 player for audio with captions either needs a custom CSS + JS implementation to display the captions OR be treated as a video (with minor CSS tweaks). i have tested this in my local, so i will try in the next week or so to get this into a cleaned up PR. |
@elizoller Cool, will be keen to see what you come up with, or whether it's easiest to embed something like webvtt-player... |
I don't know about chrome but when I was messing with video and captions, adding a thumbnail image to the player to display would let the captions be shown on top of that. |
GitHub Issue:
Islandora/documentation#1305
Islandora/documentation#1003
https://www.drupal.org/project/drupal/issues/3057144
https://www.drupal.org/project/drupal/issues/3056714
Other Relevant Links
Perhaps superseding https://github.com/Islandora/islandora/pull/743/files
Definitely supersedes Islandora/islandora_defaults#44
What does this Pull Request do?
Takes the work in the patch 16 here https://www.drupal.org/project/drupal/issues/3056714
Allows a user to add a "track" to an audio or video media object which will play in the HTML5 player
What's new?
How should this be tested?
Additional Notes
Interested parties
@Islandora/8-x-committers @Natkeeran