Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captions v2 #826

Merged
merged 5 commits into from
Mar 18, 2021
Merged

captions v2 #826

merged 5 commits into from
Mar 18, 2021

Conversation

elizoller
Copy link
Member

GitHub Issue:
Islandora/documentation#1305
Islandora/documentation#1003
https://www.drupal.org/project/drupal/issues/3057144
https://www.drupal.org/project/drupal/issues/3056714

Other Relevant Links
Perhaps superseding https://github.com/Islandora/islandora/pull/743/files
Definitely supersedes Islandora/islandora_defaults#44

What does this Pull Request do?

Takes the work in the patch 16 here https://www.drupal.org/project/drupal/issues/3056714
Allows a user to add a "track" to an audio or video media object which will play in the HTML5 player

What's new?

How should this be tested?

  • spin up an islandora site
  • pull in islandora_defaults PR captions v2 islandora_defaults#48 and this islandora PR
  • do a partial config import on the config/install directory of islandora_defaults
  • cache clear
  • add an audio and/or video node
  • add an audio and/or video original file media attached to that node
  • when the service file derivative is created, add a VTT caption file to that service file media in the new track field
  • view the node - in the menu on the HTML5 player, you should be able to toggle on and off captions

Additional Notes

Interested parties

@Islandora/8-x-committers @Natkeeran

@elizoller elizoller changed the title initial implementation of drupal core patch captions v2 Mar 9, 2021
Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! 👍

@seth-shaw-unlv seth-shaw-unlv merged commit bdf9937 into Islandora:8.x-1.x Mar 18, 2021
@kayakr
Copy link

kayakr commented Mar 23, 2021

@elizoller I can now add a .vtt track file to an audio service file but I find the default audio player in Chrome isn't showing the captions (there is a player toggle for captions, but even with captions selected, I don't see anything). In Firefox I see a CC symbol with strikethrough, and in Safari the default player doesn't seem to offer a captions toggle at all.
Can you advise re combinations of files/browser that work?

@elizoller
Copy link
Member Author

It's just using HTML5 for the player, so most modern browsers should handle it. I will look into it - what kind of audio file are you using?

@kayakr
Copy link

kayakr commented Mar 25, 2021

@elizoller The files I used are audio.mp3 and transcript.vtt from https://umd-mith.github.io/webvtt-player/annotations.html

@elizoller
Copy link
Member Author

@kayakr i have finally had a chance to look into this with more detail and discovered that, as far as i can tell, the HTML5 player for audio with captions either needs a custom CSS + JS implementation to display the captions OR be treated as a video (with minor CSS tweaks). i have tested this in my local, so i will try in the next week or so to get this into a cleaned up PR.

@kayakr
Copy link

kayakr commented Apr 15, 2021

@elizoller Cool, will be keen to see what you come up with, or whether it's easiest to embed something like webvtt-player...

@alxp
Copy link

alxp commented Apr 15, 2021

I don't know about chrome but when I was messing with video and captions, adding a thumbnail image to the player to display would let the captions be shown on top of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants