Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check audio textTracks before trying to use them for #1871 #842

Merged

Conversation

wgilling
Copy link

@wgilling wgilling commented Jul 13, 2021

GitHub Issue: (Islandora/documentation#1871)

What does this Pull Request do?

This should fix the error that was noticed with issue #1871. The adjusted code only checks that the textTracks exist before trying to loop through the cues within them to set the HTML accordingly.

How should this be tested?

To see the problem that is observed in the related issue 1871:

To test the pull request:

  1. pull in the code change for this PR
  2. Check the item that exhibited the javascript console error as above and confirm that the error message is gone.

@wgilling
Copy link
Author

updated PR to add additional configuration required to see this issue.

Copy link

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as promised.
Tested on an ISLE build.

@ajstanley ajstanley merged commit d291c62 into Islandora:8.x-1.x Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants