Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Documentation" section to pull request template #846

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Aug 11, 2021

GitHub Issue: none

in response to the ICG report, many groups have discussed improving the documentation workflow. This is a result of the Tech Call of Aug 11 2021.

What does this Pull Request do?

New section to consider in this here pull request template.

What's new?

We want to encourage documentation thoughts, if not actions, along with changes to code. We don't want to hold up the process of getting code in, but there is an implication that you should create an issue or PR to document it.

How should this be tested?

Take a look, do you think it'll be useful?

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag @Islandora/8-x-committers

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides this one minor spelling mistake, i think this addresses what we discussed at the tech call

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@dannylamb dannylamb merged commit aa94c9a into 8.x-1.x Aug 18, 2021
@seth-shaw-unlv seth-shaw-unlv deleted the rosiel-docs-section branch September 1, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants