Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 'Undefined index: rel' notice in logs #849

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

dannylamb
Copy link

GitHub Issue: Resolves Islandora/documentation#1870

What does this Pull Request do?

isset check on the rel attribute for link headers in the code that talks to Fedora.

How should this be tested?

If you were experiencing the notices in logs from Islandora/documentation#1870
, this should remove those from the logs

Documentation Status

No changes neccessary

Interested parties

@Islandora/8-x-committers

@mjordan
Copy link

mjordan commented Sep 15, 2021

I can smoke test this.

@mjordan mjordan self-requested a review September 15, 2021 17:16
@rosiel rosiel changed the base branch from 8.x-1.x to 2.x October 5, 2021 22:27
@elizoller
Copy link
Member

@mjordan do you have capacity to test this one?

@mjordan
Copy link

mjordan commented Oct 31, 2021

Can't replicate the problem reported in #1870. I just build a fresh ISLE DC using make demo (after destroying my existing images), ingested an image Repository Item with a JPG media, but I don't see any of the reported errors in the Drupal log.

However, when I click on the Fedora URI for the node, I get the following error from Fedora: "Error: No OCFL mapping found for info:fedora/b1/14/de/c6/b114dec6-56b5-4532-b8cc-49e90d29b08c". Can confirm that the image media is in Fedora (clicking on the Fedora URI for it gets me the file's entry in Fedora.

@seth-shaw-unlv
Copy link

@kayakr, would you mind testing this PR since you reported the linked issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP notice Undefined index: rel in Flysystem/Adapter/FedoraAdapter.php
4 participants