Check we're not trying to delete default media thumbnails #854
Conversation
…ng they're inaccessible
| // May not be allowed access because it is a default thumbnail for media type. | ||
| if ($field->getName() == 'thumbnail') { | ||
| $default_thumbnail_filename = $entity->getSource()->getPluginDefinition()['default_thumbnail_filename']; | ||
| $default_thumbnail_uri = \Drupal::config('media.settings') |
There was a problem hiding this comment.
Should be using dependency injection instead of the \Drupal thing... up in the ::create() method, to load up the config factory, and either pass it to the constructor to get the particular config object and then to do so inside the constructor, or to grab and pass the config object in the ::create() method to the constructor.
|
I encountered this in #960. I found that in Drupal 10 (at least), the user admin was easily able to delete the default thumbnails, causing general havoc in the site. My approach was to not consider files in the Is that an ok approach? |
|
closing as completed with #960 |
When using the "Delete media and files" views bulk operation on a FITS media type, for example, Drupal comes back saying we don't have permission to delete "x" number of files. This is because one of the files it is trying to delete is the default thumbnail for the media type. This is confusing to clients and so I suggest we remove default thumbnails from the list of inaccessible entities.
GitHub Issue: (link)
What does this Pull Request do?
Removes default thumbnails from the list of inaccessible entities when deleting multiple media and files.
What's new?
A in-depth description of the changes made by this PR. Technical details and
possible side effects.
How should this be tested?
Create a media item on a repository item which uses a default thumbnail (eg: FITs), then use the "Delete media and files" action on it and you should see a warning: "X items have not been deleted because you do not have the necessary permissions".
Checkout this pull request branch, repeat steps above and you should not see the warning.
Documentation Status
This is under-the-hood, shouldn't need any docs updated.
Additional Notes:
Let me know if I'm using the system incorrectly, and/or whether there is a better solution to this.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers