Update testing #861
Merged
Update testing #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because I changed the way the test runs are named, the expected tests are run but named differently. We'll need someone with access to change the required status checks if this is to be merged. |
|
@whikloj, I think I have the necessary permissions. Can you be more specific about what I need to update? |
|
@seth-shaw-unlv Settings -> Branches -> Branch Protection Rules (for 2.x) -> Edit -> Protect matching branches Here you want to remove the old checks and then ✅ off the rules we want to require for PRs. |
|
Branch protections have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: n/a
What does this Pull Request do?
Updates the testing matrix to pull the current minor version instead of locking.
This will test:
Only number 1 above is required to pass, the others can fail.
How should this be tested?
Changes testing matrix
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers