-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Test matrix: remove php7.3, mysql5.7. #886
Conversation
After thought and discussion with @alxp , it's probably more useful to use tests to look forward (even if they fail, as they do, on our dependencies like Stomp isn't yet PHP 8.1 friendly and Contexts won't install on D10), rather than have the nice green checkmark in the pull request list 😢. So...
In order to make it easier for PR reviewers to understand the test output, we can use the Branch protection's "required tests" - they show up with a special "Required" badge, and I guess we can use that to evaluate if the PR is ready to merge. (we'll need to change the required tests for this PR to be merged) |
It might be time to update the rest of islandora's testing matrices too. I propose:
Open questions for Drupal:
|
Discussion from the tech call:
|
I finally went with my conscience, and removed php 8.1 and drupal 10 since we haven't had a chance to actually address them yet, and made issues about what we know so far. This way,
|
GitHub Issue: #885
Discussion on Slack: https://islandora.slack.com/archives/CM5PPAV28/p1658234802046979 (no replies yet)
What does this Pull Request do?
Updates the testing matrix
What's new?
How should this be tested?
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers