Filehash Fixes and improve checksum view #912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1931
Islandora requires the filehash module, and provides (in the core features) settings(!!) and a view that use it.
Since the update to filehash 2, the view has been broken. (Filehash 2 stores data in fields on files, so the plugin handler was different)
Also! Filehash 2 provides some great features:
Is it the be-all-and-end-all of preservation fixity for a repository? No! lol, but we can do a lot more with it now than we could before.
What does this Pull Request do?
Updates the settings and view to work with the new filehash module.
What's new?
(i.e. Regeneration activity, etc.)? Upgrade will involve regenerating filehashes.
How should this be tested?
Load the starter site. (or try to update filehash to 2.x on the install profile?)
Go to the View "File checksums" and see it's missing a handler.
Load this PR.
Go to the Islandora Core Feature, in Features.
Select views.view.file_checksum and filehash.settings, and import the changes.
Create some test files.
Go to the View. It should not be broken. Test at /checksums/1 (replace 1 with your file id) and see a JSON array containing checksums, including 'sha1
and
original_sha1`Note: Derivatives will have empty original_sha1. The derivative code
create
s the file empty, thenupdate
s it with the content.Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers