Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crayfish Commons dependency #933

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Update Crayfish Commons dependency #933

merged 1 commit into from
Mar 13, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Mar 8, 2023

** Related tickets**:

What does this Pull Request do?

Changes the islandora module to use Crayfish Commons v3 (which has been out for almost a year)

What's new?

Updates Crayfish Commons to the next major version. The release notes do not give any indication that this is a breaking change, but it uses Symfony (hopefully removing some dependencies on deprecated items).

  • Does this change add any new dependencies? This is a change to dependencies.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? Don't think so.
  • Could this change impact execution of existing code? Don't think so.

How should this be tested?

  • I know that Crayfish Commons is used to generate the Fedora URIs. So if you load this, your Fedora URIs should still work.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu requested a review from alxp March 8, 2023 18:18
Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-asu seth-shaw-asu merged commit bb06d81 into 2.x Mar 13, 2023
@seth-shaw-asu seth-shaw-asu deleted the rosiel-patch-1 branch March 13, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants