Update Crayfish Commons dependency #933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Related tickets**:
Update Crayfish to use 3.0.0 and/or 3.x Islandora-Devops/islandora-playbook#233
Update Crayfish to use 3.x Islandora-Devops/isle-buildkit#249
Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.)
[BUG] Conflict with Drupal LDAP module Crayfish-Commons#59 (possibly)
What does this Pull Request do?
Changes the islandora module to use Crayfish Commons v3 (which has been out for almost a year)
What's new?
Updates Crayfish Commons to the next major version. The release notes do not give any indication that this is a breaking change, but it uses Symfony (hopefully removing some dependencies on deprecated items).
(i.e. Regeneration activity, etc.)? Don't think so.
How should this be tested?
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers