Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping out json metadata in the queue messages except for the ones… #973

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

dannylamb
Copy link

… java is expecting

GitHub Issue: #972

What does this Pull Request do?

Filters out everything that goes into the json blob on queue messages other than what Camel is expecting on the other side.

How should this be tested?

  • Install VBO
  • Add the VBO widget to a view
  • Try to use the VBO widget to perform a derivative action, like "Generate an image derivative"
    image
  • Fill out the little form it makes you fill out. This makes it regen the service file as a jpeg
    image

Before fix

  • Alpaca logs will contain
alpaca_1 | 2023-08-24T00:41:11.804751513Z 2023-08-24 00:41:11,804 | ERROR | nnector-houdini] | DefaultErrorHandler | 56 - org.apache.camel.camel-core - 2.20.4 | Failed delivery for (MessageId: ID:484a3574eabd-35331-1690401177428-3:137507👎1:19 on ExchangeId: ID-5c8908e3ad99-1690401207016-3-731092). Exhausted after delivery attempt: 11 caught: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "add_confirmation" (class ca.islandora.alpaca.support.event.AS2AttachmentContent), not marked as ignorable (7 known properties: "file_upload_uri", "fedora_uri", "source_uri", "destination_uri", "args", "mimetype", "source_field"])
  • You will not have new derivatives

After fix

  • Alpaca logs will not have the error message above
  • You will have new derivatives

Documentation Status

  • Does this change require new pages or sections of documentation?
    • Might wanna mention you're VBO compatible somewhere

Interested parties

@Islandora/committers

@seth-shaw-asu seth-shaw-asu self-requested a review August 30, 2023 17:16
@rosiel rosiel requested review from rosiel and removed request for seth-shaw-asu September 13, 2023 17:12
@rosiel rosiel merged commit e3399d3 into Islandora:2.x Sep 20, 2023
rosiel pushed a commit to rosiel/islandora that referenced this pull request Oct 23, 2023
rosiel pushed a commit to rosiel/islandora that referenced this pull request Oct 23, 2023
…iif-hooks

Issue Islandora#973 Add hooks to IIIF manifest Views Style plugin.
rosiel pushed a commit to rosiel/islandora that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants