Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #975
Release pull requests, etc.)
What does this Pull Request do?
Removes a deprecation notice outlined in the above issue.
What's new?
Declare a variable that was being dynamically assigned.
How should this be tested?
Testing instructions to come.
Edit: Not sure how to make the errors show up, but an IDE (the built-in one in site-template) shows the lack of declaration of this variable as a problem.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
@alxp, @Islandora/committers